Files
STM32F4-Base/.dsh
wandering1 1481518d4b docs(roles): add acceptance-stage rules that check the checker
The acceptance stage has no stage above it. An executor's work is
reviewed by a reviewer, but the reviewer's own conclusion is never
reviewed. These rules close that gap: they do not raise the bar, they
make the reviewer state how much its own conclusion can be trusted.

Three rules go under a new subsection of the acceptance section in
lead-orchestrator.md, and a condensed action version goes into
code-reviewer.md, because that file is the persona injected into
reviewer teammates while lead-orchestrator.md is not.

Rule one: before rejecting, run your own check on an input known to be
good. A check that only ever turns green is not a check. When you can
only afford one direction, test the one that should turn red. Building
a counter-example has three cost tiers, cheapest first: replay a
recorded failure, change one byte, or construct a case from scratch.
For the first tier the sample must itself be known good and its defect
already located, otherwise you are validating your check against a
guess.

Rule two: write every technical claim in a task brief as unverified, and
say so, so that the executor checks it rather than trusting it. This
upgrades an earlier note that merely allowed the Lead to invite
pushback into a default shape for every brief.

Rule three: copy out every proper name and every number in the text
under review and check each one individually. The list must also cover
your own check and its inputs, because a check that is wrong is the one
thing you will not think to check.

Separately, a table in the acceptance section now requires the evidence
behind any conclusion to be labelled: static, build, runtime that the
reviewer can rerun, or runtime that needs the board. A conclusion the
reviewer cannot reproduce stays marked as unverified.

Everything here came out of two rounds of review that went wrong in the
same way. Both times an error was written into an accepted document and
survived because nobody re-checked the source of the claim.

Verification:
- anti-pattern table still has 14 rows, all sections present
- rule boundaries differ between the two files; the cross-reference
  therefore names the section rather than a rule number
- CRLF 0, no BOM, bom drift check passes
- doc link check reports the same 6 pre-existing issues, none here
- mojibake check passes
- the self-check script prints what it scanned and turns red when a
  regression is injected
2026-11-16 20:28:32 +08:00
..